Skip to content

feat(config): trigger the config.toml migration at startup#245

Merged
LorrisSaintGenez merged 2 commits into
feat/profile-migrationfrom
feat/migration-trigger
Jun 12, 2026
Merged

feat(config): trigger the config.toml migration at startup#245
LorrisSaintGenez merged 2 commits into
feat/profile-migrationfrom
feat/migration-trigger

Conversation

@LorrisSaintGenez

Copy link
Copy Markdown
Contributor

What

Step 1 of GROUT-363 — wires the one-time config.toml → state.toml + keychain migration trigger, without the migration body yet.

  • Config.ShouldMigrate(): true when config.toml exists and state.toml doesn't. state.toml is only written when the migration (or any new-model write) succeeds, so its absence doubles as the "not migrated yet" marker — an aborted migration naturally retries on the next run, no separate flag needed.
  • Config.Migrate(): deliberate no-op for now — it must NOT write state.toml, otherwise the trigger would stop firing before the real migration ships. The body lands in the follow-up PRs (per-profile move, skip rules, atomicity).
  • Call site in Execute(), right after InitConfig(): the migration has to run before the command executes because credential resolution reads state.toml once per invocation and caches it. A migration failure never blocks the command (logged in debug mode only).

Test

Unit tests only — Migrate is still a no-op, so there is no observable CLI behavior yet:

go test ./pkg/config -run TestConfig_ShouldMigrate -v

GROUT-363

ShouldMigrate fires when config.toml exists and state.toml doesn't:
state.toml is only written on success, so its absence doubles as the
"not migrated yet" marker and an aborted run retries on the next one.
Migrate is a deliberate no-op until the migration body lands.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Jun 11, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 33 complexity · 3 duplication

Metric Results
Complexity 33
Duplication 3

View in Codacy

TIP This summary will be updated as you push new changes.

…toml (#246)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@LorrisSaintGenez LorrisSaintGenez marked this pull request as ready for review June 12, 2026 21:09
@LorrisSaintGenez LorrisSaintGenez merged commit f17369c into feat/profile-migration Jun 12, 2026
1 of 2 checks passed
@LorrisSaintGenez LorrisSaintGenez deleted the feat/migration-trigger branch June 12, 2026 21:09
LorrisSaintGenez added a commit that referenced this pull request Jun 15, 2026
…#248)

* feat(config): trigger the config.toml migration at startup (#245)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* chore(config): slim down the migration comments

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(config): harden the migration against bad config.toml files

Two startup-path regressions found while testing edge cases:

- An undecodable profile (root-level scalar, unconvertible field type)
  hit ConfiguredProfiles' log.Fatalf and bricked every command, --help
  included, forever (state.toml never written). The migration now
  decodes profiles itself and skips undecodable entries with a log.
- An unparseable config.toml was silently read as zero profiles, so an
  empty state.toml marked the migration as done forever. Migrate now
  aborts when config.toml cannot be parsed and retries on the next run.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(config): migrate search_hosts and crawler_user_id to state.toml

The remaining non-secret profile data moves with the migration so it
survives the eventual config.toml removal. GetSearchHosts and
GetCrawlerUserID gain a new-model branch: the resolved application's
state.toml entry answers first, an empty value falls through to the
legacy config.toml lookup while both models coexist. admin_api_key
stays excluded as decided on the ticket.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(config): omit empty api_key_uuid from state.toml

Legacy migrated keys have no UUID, so without omitempty every migrated
entry serialized a noisy api_key_uuid = "". The field is only set by
new-model writes (app create/select); omitting the empty value matches
search_hosts/crawler_user_id and reads back identically.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(application): mark configured apps in select from state.toml

The select picker decorated choices from config.toml profiles only, so
apps configured under the new model showed as unconfigured. It now marks
an app "(configured)" when state.toml holds an entry for it, falling back
to legacy config.toml profiles while config.toml is still supported.

Adds Config.ApplicationInState for the state-only lookup.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(application): state-aware "configured" marker + describe without auth

Two follow-ups from auditing the command tree against state.toml:

- application list marked apps configured from config.toml profiles only,
  so new-model apps showed as "(not configured)". It now uses the same
  state-first/config-fallback check as the select picker, centralized in
  apputil.ApplicationConfigured.
- describe walks the command tree and needs no credentials, but lacked
  skipAuthCheck so it failed on a machine with nothing configured. It now
  skips the auth check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(config): clearer error when the current app has no keychain key

When state.toml resolves a current application but its key isn't in this
machine's keychain (e.g. state.toml synced across machines without it),
GetAPIKey/GetCrawlerAPIKey returned the generic "not configured yet". The
error now names the application and points to the fix (`application
select` / `auth crawler`, or the matching env var). Re-authenticating
rewrites the keychain entry, so it restores a working state.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf(config): short-circuit ShouldMigrate on the state.toml check

Check state.toml first: an already-migrated machine (the steady state,
hit on every command) now settles in a single stat instead of also
stat-ing config.toml. The boolean result is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf(application): O(1) configured-app lookup when listing/selecting

Marking apps "(configured)" called ConfiguredProfiles() (a full viper
re-parse) once per application — O(apps × profiles) with a heavy
constant. Now the config.toml profile app IDs are collected once into a
set (ProfileApplicationIDs); the per-app check is two O(1) map lookups
(cached state.toml + the set). Both `application list` and `application
select` build the set once before their loop.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant